Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive - Dangerous props #181

Open
ThaChillera opened this issue Aug 7, 2021 · 11 comments
Open

False positive - Dangerous props #181

ThaChillera opened this issue Aug 7, 2021 · 11 comments

Comments

@ThaChillera
Copy link

Hi,

I have a fairphone 3+ with a custom rom (lineageOS microG), but I don't have, and have never, had root. Your test app triggers on 'dangerous props', but I'm not really sure what that check does, so even though it looks like a false positive, it might be due to my custom rom!

Let me know if I can test anything for you guys

@Ktirumalsetty
Copy link

Any resolution for this i got this issue in onelus ce

@NezumiRyu
Copy link

Function: checkForDangerousProps()
Checking ro.debuggable and ro.secure

@smurfy
Copy link

smurfy commented Apr 21, 2023

Same issue with lineage 20 on oneplus 6t. DangerousProps check triggers

@fbobraga
Copy link

fbobraga commented Sep 2, 2023

Same here on Oneplus 5T with LOS 20

@gehaxelt
Copy link

Same here. What are the offending props? How can we fix this? It's preventing me from using normal apps on my deliberately root-free phone :-(

@smurfy
Copy link

smurfy commented Sep 26, 2023

My "fix" is editing /system/build.prop on my lineage 20 phone.

I mainly need to change ro.debuggable to 0 and then reboot

adb root
adb remount
adb shell
mount -o rw,remount /
nano /system/build.prop

ro.secure=0 # should be 1
ro.debuggable=1 # should be 0
ro.build.type=userdebug" # should be "user"

@fbobraga
Copy link

fbobraga commented Sep 26, 2023 via email

@smurfy
Copy link

smurfy commented Sep 26, 2023

Same here. What are the offending props? How can we fix this? It's preventing me from using normal apps on my deliberately root-free phone :-(

on LOS 20 its only ro.debuggable=1

@KebabLord
Copy link

My "fix" is editing /system/build.prop on my lineage 20 phone.

I mainly need to change ro.debuggable to 0 and then reboot

adb root
adb remount
adb shell
mount -o rw,remount /
nano /system/build.prop

ro.secure=0 # should be 1
ro.debuggable=1 # should be 0
ro.build.type=userdebug" # should be "user"

thanks for the info mate, that saved my day.

additionally in order to pass the "test keys" check, one can replace the "test-keys" with "release-keys" on build.prop

@AsbjornOlling
Copy link

AsbjornOlling commented Mar 21, 2024

This is affecting a lot of people in Denmark, since a few days ago.
The app MobilePay is the ubiquitous mobile-payments app here.I think that the vast majority of persons in Denmark use this app daily or weekly for payments. I would estimate that MobilePay has close to 5 million active users.

They recently released a total rewrite of the app, which now uses rootbeer. Non-standard Android devices (without root!), like ones that run LineageOS or /e/OS or similar, refuse to launch the app, because of this false positive bug. This is a big problem for a lot of people.

I have already seen a handful of people posting links to this workaround, to get mobilepay working again. I've seen people talking about this on reddit, on mastodon, in discord servers, and in matrix group chats.
I'm not sure what percentage of Android users run LineageOS or similar, but I expect that this is affecting thousands of people.

Frankly, it's really annoying and a bit embarrassing for this project, that a 3-year old known bug has not been addressed, and is now blocking thousands of people from making payments.

@KebabLord
Copy link

@AsbjornOlling I totally agree with you, Tachi107 already created a PR fixing this issue (#192 ) but maintainer simply answered "Oz" to his PR and didn't merge it for 2 years. I hate this type of repo maintainers. They can just archive it if they'll never respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants