Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpack #91

Merged
merged 1 commit into from
Feb 15, 2016
Merged

Fix webpack #91

merged 1 commit into from
Feb 15, 2016

Conversation

tontonAurel
Copy link

No description provided.

@tontonAurel tontonAurel mentioned this pull request Dec 17, 2015
@uyson
Copy link

uyson commented Jan 4, 2016

+1

@mathroc
Copy link
Contributor

mathroc commented Jan 25, 2016

+1 builds on ci seems to have failed because of a problem with saucelabs, can someone restart the tests on travis for this PR ?

@elmariofredo
Copy link

+1 seems to be problem with Sauce Labs credentials. Tests are passing on local.

@elmariofredo
Copy link

@tontonAurel I would suggest to rebase your changes on current master, which would trigger new CI build and then @ocombe would hopefully have easy choice to merge it.

Thanks!

@ocombe
Copy link
Collaborator

ocombe commented Feb 15, 2016

Sorry that's my fault. I need to get back into this project sometimes but I don't really have the time right now.
Also CI is broken for PRs because of sauce labs (I don't know why, probably a config problem).

ocombe added a commit that referenced this pull request Feb 15, 2016
@ocombe ocombe merged commit fc0f847 into scotttrinh:master Feb 15, 2016
@elmariofredo
Copy link

Thanks @ocombe!

p.s. It seems that sauce labs now require to set username and access_key as per docs https://docs.travis-ci.com/user/sauce-connect/#Setting-up-Sauce-Connect
Just for future reference not pushing ;) I'm sure that you have lots of other better things to do.

@elmariofredo
Copy link

@ocombe can we release this merge request pretty please :)

@MrJuliuss
Copy link

+1, need a release :)

@de-luca
Copy link

de-luca commented Apr 12, 2016

+1

@scotttrinh
Copy link
Owner

I'll take a look at getting this merged correctly, if it hasn't already been handled. Stay tuned!

@scotttrinh scotttrinh added the bug label Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants