Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump localforage dependency to 1.5 #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NeverwinterMoon
Copy link
Contributor

There are a few things that make 1.5 more desirable over 1.4 - one being this one
localForage/localForage#633. Then again, 1.5 has one breaking change: https://github.com/localForage/localForage/releases/tag/1.5.0

This affects only the projects that use npm packaging (browserify/webpack)

There are a few things that make 1.5 more desirable over 1.4 - one being this one 
localForage/localForage#633. Then again, 1.5 has one breaking change: https://github.com/localForage/localForage/releases/tag/1.5.0

This affects only the projects that use npm packaging (browserify/webpack)
@scotttrinh
Copy link
Owner

@NeverwinterMoon

I've considered this same thing, actually. However, I feel like the Safari breaking change is enough to keep me from wanting to do this without bumping our major version number, which I would want to bundle up with some other breaking changes we've been considering.

I'd be open to accepting this PR if we also incorporated https://github.com/localForage/localForage-compatibility-1-4 so to avoid the breaking change for now. What do you think?

@NeverwinterMoon
Copy link
Contributor Author

@scotttrinh This does make sense to me, sure. I will try to incorporate the compatibility code and come back with the adjusted PR. Can't give any estimations yet as it's a bit hectic at work now.

@scotttrinh
Copy link
Owner

Thanks, @NeverwinterMoon! Let me know if there is anything I can do to support you.

@mcarriere
Copy link

Any plans to make this happen?

@scotttrinh
Copy link
Owner

@mcarriere Nothing currently in the works, but I'd be happy to help with anyone who wants to take a stab at a PR. I no longer use it for my daily work, so I'd hope it would be driven mostly from people who do use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants