-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removeItem needs to use prefix #4
Comments
You are right, I'm fixing it and updating the adapter for the new config option of localforage at the same time. The update should come soon :) |
ocombe
added a commit
that referenced
this issue
Mar 19, 2014
* Added a changelog ! * Using localForage 0.1.1 with the new config options * **Breaking change**: setPrefix has been removed, use the config function from now on * Renamed all the functions to keep consistency with the localForage function names (set/get/remove/clearAll/getKeyAt/getLength/getDriver are renammed setItem/getItem/removeItem/clear/key/length/driver). The old function names are still available. * Added a test to check for "InvalidStateError" due to private browsing in firefox and switching to localstorage when this is the case * Fixed bug #4 [removeItem needs to use prefix](#4) * Added missing package.json (for tests) and updated tests
Fixed with the new release 0.1.0, be careful there is a breaking change with setPrefix: https://github.com/ocombe/angular-localForage/releases/tag/0.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
like setItem & getItem, removeItem needs to use the prefix: https://github.com/ocombe/angular-localForage/blob/master/angular-localForage.js#L85
The text was updated successfully, but these errors were encountered: