-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding second footprint for 3V3 voltage regulator #98
Adding second footprint for 3V3 voltage regulator #98
Conversation
…different pinout. Updating .gitignore for ignoring Mac files and more Kicad backups
Its no big deal to me, was something I first noticed when looking at the board in the 3D Viewer, Its not a game breaker, but imo having the label visable might help with helping others debug things later down the road (However it also won't be hard to ask "is it the left or right footprint you haave populated?"). Just thinking forward thats all.
Doh, ofcause it is, Brain was obv not firing on all cylinders. EDIT: on further thinking, might be better to change it to something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks for the PR! A couple thoughts:
- What's the reason for using global labels for power nets rather than the standard symbols (which are already global)?
- I'm wondering about the net renumbering (see inline comment) - maybe related to the added global labels?
- trace width - would be good to keep this consistent as mentioned
…usting .gitignore
Thanks for reviewing! No good reason for using global labels, I was attempting to make it easier to read in my mind, but I think it just made it messier. The global labels do seem to be a direct cause of the net re-numbering as well. Went ahead and fixed the trace widths and adjusted the schematic to just use the standard power symbols instead. Let me know if you'd like me to redo this to preserve the original net numberings. |
Thanks again for the PR! FYI I did a little cleanup in 04475a8 - I moved the LDOs so they mirror each other on the board, and updated the footprints to label the IN/GND/OUT pins on each to hopefully make the pinout distinction more obvious. Also added part numbers for the new LDO U9 and notes on both mentioning to only populate one or the other. Also a little bit of tidying the schematic. |
@scottbez1 Thanks for approving! Love the cleanup and clarifications you made. |
The voltage regulator that was originally used isn't available at the moment. To provide more options, a second footprint was added to the PCB for an alternative regulator that has a different pinout. Important to note that only one regulator should be used. Also, adjusted .gitignore for Mac files and KiCad auto-generated backups.
The voltage regulator that was originally used isn't available at the moment. To provide more options, a second footprint was added to the PCB for an alternative regulator that has a different pinout. Important to note that only one regulator should be used.
Also, adjusted .gitignore for Mac files and KiCad auto-generated backups.