-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: how --json
parameter output is handled
#608
Conversation
Code Climate has analyzed commit cfac679 and detected 0 issues on this pull request. View more on Code Climate. |
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 898 898
=========================================
Hits 898 898 ☔ View full report in Codecov by Sentry. |
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected] |
Explain your changes
Returned the result object so
--json
handler can use it to display result when the flag is setDoes this close any currently open issues?
closes #568
This fix will not handle the warning in the error array.
The git diff command in this case does not throw an error (exit code is 0) but write the warning message in
stderr
We catch every error message from
stderr
to treat those as error and stop execution, by design.