Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: husky postinstall issue #336

Merged
merged 5 commits into from
Aug 26, 2022
Merged

fix: husky postinstall issue #336

merged 5 commits into from
Aug 26, 2022

Conversation

scolladon
Copy link
Owner

What does this pull request contain?


  • Added (for new features).
  • Changed (for changes in existing functionality).
  • Deprecated (for soon-to-be removed features).
  • Removed (for now removed features).
  • Fixed (for any bug fixes).
  • Security (for vulnerability fixes).

Explain your changes


Bypass husky installation for production environment

Husky is set as a dev dependency in the project
Installation in production environment bypass the installation of dev dependency (no need).
Our prepare script install husky (as recommended in their documentation) but cannot find husky in production environment.
A check as been added to bypass husky installation for production environment.

Does this close any currently open issues?


closes #334

Any particular element that can be tested locally


install the project using yarn install --prod
With previous version it fails, with new version it succeed

@scolladon scolladon requested a review from mehdicherf as a code owner August 26, 2022 08:49
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #336 (68514cc) into main (6e38556) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #336   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          730       730           
=========================================
  Hits           730       730           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mehdicherf
mehdicherf previously approved these changes Aug 26, 2022
@codeclimate
Copy link

codeclimate bot commented Aug 26, 2022

Code Climate has analyzed commit 68514cc and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon changed the title fix: husky install issue in production environment fix: husky postinstall issue Aug 26, 2022
@scolladon scolladon merged commit 16b249b into main Aug 26, 2022
@scolladon scolladon deleted the fix/husky-postinstall branch August 26, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install plugin after 5.4.0 release
2 participants