Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add big object index support #330

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Conversation

scolladon
Copy link
Owner

What does this pull request contain?


  • Added (for new features).
  • Changed (for changes in existing functionality).
  • Deprecated (for soon-to-be removed features).
  • Removed (for now removed features).
  • Fixed (for any bug fixes).
  • Security (for vulnerability fixes).

Explain your changes


Add configuration to include Sub Custom Object Index metadata for big object

Does this close any currently open issues?


closes #327

  • Jest test added to check the fix is applied.

@scolladon scolladon requested a review from mehdicherf as a code owner August 18, 2022 17:39
@codeclimate
Copy link

codeclimate bot commented Aug 18, 2022

Code Climate has analyzed commit f207f73 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #330 (f207f73) into main (5e2cb9a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #330   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          633       633           
=========================================
  Hits           633       633           
Impacted Files Coverage Δ
src/service/typeHandlerFactory.js 100.00% <ø> (ø)
src/utils/metadataConstants.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mehdicherf mehdicherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scolladon scolladon merged commit 2d2ce50 into main Aug 25, 2022
@scolladon scolladon deleted the feat/big-object-index-support branch August 25, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Big object Deployment Issue as it is causing build failures
2 participants