Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve guidance for Windows users #138

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Conversation

mehdicherf
Copy link
Collaborator

What does this pull request contains

Update README to inform Windows users of the need for double quotes

Does this close any currently open issues?

closes #134

@codeclimate
Copy link

codeclimate bot commented Apr 28, 2021

Code Climate has analyzed commit 4c59cd8 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #138 (4c59cd8) into master (a0f6eb8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          18       18           
  Lines         402      402           
=======================================
  Hits          399      399           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f6eb8...4c59cd8. Read the comment docs.

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: clear concise and nicely placed 👍

@scolladon scolladon changed the title Update README docs: improve guidance for Windows users Apr 28, 2021
@scolladon scolladon merged commit bb45bef into master Apr 28, 2021
@scolladon scolladon deleted the feature/improve-readme branch April 28, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Windows it does not work all the time it seems
2 participants