Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement flow translation addition #322

Merged
merged 30 commits into from
Aug 25, 2022

Conversation

scolladon
Copy link
Owner

What does this pull request contain?


  • Added (for new features).
  • Changed (for changes in existing functionality).
  • Deprecated (for soon-to-be removed features).
  • Removed (for now removed features).
  • Fixed (for any bug fixes).
  • Security (for vulnerability fixes).

Explain your changes


Implement a new type handler for flow
When a flow is added or changed if it is referenced in a translation file then the translation file is added in the package and in the output directory as well

Does this close any currently open issues?


closes #321

  • Jest test added to check the fix is applied.

Any particular element that can be tested locally


Use the branch issue/321 of the playground

src/post-processor/flowTranslationProcessor.js Outdated Show resolved Hide resolved
src/utils/fsHelper.js Show resolved Hide resolved
src/post-processor/packageGenerator.js Show resolved Hide resolved
src/post-processor/packageGenerator.js Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #322 (e962179) into main (5e2cb9a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #322   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        29    +6     
  Lines          633       730   +97     
=========================================
+ Hits           633       730   +97     
Impacted Files Coverage Δ
src/main.js 100.00% <100.00%> (ø)
src/post-processor/baseProcessor.js 100.00% <100.00%> (ø)
src/post-processor/flowTranslationProcessor.js 100.00% <100.00%> (ø)
src/post-processor/packageGenerator.js 100.00% <100.00%> (ø)
src/post-processor/postProcessorManager.js 100.00% <100.00%> (ø)
src/service/botHandler.js 100.00% <100.00%> (ø)
src/service/customObjectHandler.js 100.00% <100.00%> (ø)
src/service/inFileHandler.js 100.00% <100.00%> (ø)
src/service/inFolderHandler.js 100.00% <100.00%> (ø)
src/service/inResourceHandler.js 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scolladon scolladon force-pushed the feat/flow-translation-support branch from bc82834 to 3f8a751 Compare August 5, 2022 16:37
@scolladon scolladon marked this pull request as ready for review August 6, 2022 23:36
@scolladon scolladon requested a review from mehdicherf as a code owner August 6, 2022 23:36
@scolladon scolladon force-pushed the feat/flow-translation-support branch from 0f7848b to dbf0410 Compare August 6, 2022 23:39
@scolladon scolladon force-pushed the feat/flow-translation-support branch from dbf0410 to 9b0a88d Compare August 6, 2022 23:43
@scolladon scolladon force-pushed the feat/flow-translation-support branch 2 times, most recently from 0659682 to d91c20b Compare August 8, 2022 08:13
@scolladon scolladon force-pushed the feat/flow-translation-support branch from d91c20b to 5eb5c2d Compare August 15, 2022 14:53
@scolladon scolladon force-pushed the feat/flow-translation-support branch from 5eb5c2d to e962179 Compare August 18, 2022 17:55
@codeclimate
Copy link

codeclimate bot commented Aug 18, 2022

Code Climate has analyzed commit e962179 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@mehdicherf mehdicherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice new feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants