feat: add ConversationMessageDefinition metadata support (#899)

scolladon · Aug 5, 2024 · 50188cf · 50188cf
1 parent 41819da
commit 50188cf
Show file tree

Hide file tree

Showing 9 changed files with 1,006 additions and 480 deletions.
diff --git a/__tests__/__utils__/globalTestHelper.ts b/__tests__/__utils__/globalTestHelper.ts
@@ -6,8 +6,6 @@ import {
 } from '../../src/metadata/metadataManager'
 import type { Work } from '../../src/types/work'
 
-require('ts-node/register')
-
 export const getGlobalMetadata = async (): Promise<MetadataRepository> => {
   const apiVersion: number = await getLatestSupportedVersion()
   const metadata: MetadataRepository = await getDefinition(apiVersion)

diff --git a/__tests__/functional/main.test.ts b/__tests__/functional/main.test.ts
@@ -1,8 +1,8 @@
-;`use strict`
+'use strict'
 import { expect, jest, describe, it } from '@jest/globals'
 
-// eslint-disable-next-line @typescript-eslint/no-var-requires
-const sgd = require('../../src/main')
+import sgd from '../../src/main'
+import type { Config } from '../../src/types/config'
 
 const mockValidateConfig = jest.fn()
 jest.mock('../../src/utils/cliHelper', () => {
@@ -57,7 +57,7 @@ describe('external library inclusion', () => {
 
       // Act
       try {
-        await sgd({})
+        await sgd({} as Config)
       } catch (error) {
         // Assert
         expect((error as Error).message).toEqual('test')
@@ -72,7 +72,7 @@ describe('external library inclusion', () => {
     })
     it('it should not process lines', async () => {
       // Act
-      await sgd({})
+      await sgd({} as Config)
 
       // Assert
       expect(mockProcess).toBeCalledWith([])
@@ -86,7 +86,7 @@ describe('external library inclusion', () => {
     })
     it('it should process those lines', async () => {
       // Act
-      await sgd({})
+      await sgd({} as Config)
 
       // Assert
       expect(mockProcess).toBeCalledWith(['line'])

diff --git a/package.json b/package.json
@@ -26,7 +26,7 @@
   "author": "Sebastien Colladon <[email protected]>",
   "dependencies": {
     "@salesforce/command": "^5.3.9",
-    "@salesforce/core": "^8.2.7",
+    "@salesforce/core": "^8.2.8",
     "async": "^3.2.5",
     "fast-xml-parser": "^4.4.1",
     "fs-extra": "^11.2.0",
@@ -224,18 +224,18 @@
     "@jest/globals": "^29.7.0",
     "@ls-lint/ls-lint": "^2.2.3",
     "@oclif/dev-cli": "^1.26.10",
-    "@salesforce/cli-plugins-testkit": "^5.3.20",
+    "@salesforce/cli-plugins-testkit": "^5.3.23",
     "@salesforce/dev-config": "^4.1.0",
-    "@salesforce/ts-sinon": "^1.4.23",
-    "@stryker-mutator/core": "^8.2.6",
-    "@stryker-mutator/jest-runner": "^8.2.6",
-    "@swc/core": "^1.7.3",
+    "@salesforce/ts-sinon": "^1.4.24",
+    "@stryker-mutator/core": "^8.3.0",
+    "@stryker-mutator/jest-runner": "^8.3.0",
+    "@swc/core": "^1.7.6",
     "@types/async": "^3.2.24",
     "@types/jest": "^29.5.12",
     "@types/mocha": "^10.0.7",
-    "@types/node": "^22.0.0",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
+    "@types/node": "^22.1.0",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
     "benchmark": "^2.1.4",
     "chai": "^4.3.10",
     "eslint": "^8.57.0",
@@ -245,13 +245,13 @@
     "husky": "^9.1.4",
     "jest": "^29.7.0",
     "knip": "^5.27.0",
-    "lint-staged": "^15.2.7",
+    "lint-staged": "^15.2.8",
     "mocha": "^10.7.0",
     "nyc": "^17.0.0",
     "prettier": "^3.3.3",
     "shx": "^0.3.4",
     "sinon": "^18.0.0",
-    "ts-jest": "^29.2.3",
+    "ts-jest": "^29.2.4",
     "ts-node": "^10.9.2",
     "tslib": "^2.6.3",
     "typescript": "^5.5.4",

diff --git a/src/metadata/v59.json b/src/metadata/v59.json
@@ -1,4 +1,11 @@
 [
+  {
+  "directoryName": "conversationMessageDefinitions",
+  "inFolder": false,
+  "metaFile": false,
+  "suffix": "conversationMessageDefinition",
+  "xmlName": "ConversationMessageDefinition"
+  },
   {
     "directoryName": "dw",
     "inFolder": false,

diff --git a/src/metadata/v60.json b/src/metadata/v60.json
@@ -1,4 +1,11 @@
 [
+  {
+  "directoryName": "conversationMessageDefinitions",
+  "inFolder": false,
+  "metaFile": false,
+  "suffix": "conversationMessageDefinition",
+  "xmlName": "ConversationMessageDefinition"
+  },
   {
   "directoryName": "genAiPromptTemplateActivations",
   "inFolder": false,

diff --git a/src/metadata/v61.json b/src/metadata/v61.json
@@ -1,4 +1,11 @@
 [
+  {
+  "directoryName": "conversationMessageDefinitions",
+  "inFolder": false,
+  "metaFile": false,
+  "suffix": "conversationMessageDefinition",
+  "xmlName": "ConversationMessageDefinition"
+  },
   {
   "directoryName": "genAiPromptTemplateActivations",
   "inFolder": false,

diff --git a/src/utils/cliHelper.ts b/src/utils/cliHelper.ts
@@ -46,7 +46,7 @@ export default class CLIHelper {
         try {
           const ref: string = await this.gitAdapter.parseRev(shaValue)
           ;(this.config[shaParameter] as string) = ref
-        } catch (error) {
+        } catch {
           errors.push(
             format(messages.errorParameterIsNotGitSHA, shaParameter, shaValue)
           )

diff --git a/src/utils/fsHelper.ts b/src/utils/fsHelper.ts
@@ -43,7 +43,7 @@ export const readPathFromGit = async (forRef: FileGitRef, config: Config) => {
   try {
     const gitAdapter = GitAdapter.getInstance(config)
     utf8Data = await gitAdapter.getStringContent(forRef)
-  } catch (error) {
+  } catch {
     /* empty */
   }
   return utf8Data