Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass tmt_plan_filter to TF even when tmt_hardware input is undefined #231

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Sep 6, 2024

@jamacku jamacku requested a review from phracek September 6, 2024 08:38
@jamacku jamacku linked an issue Sep 6, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.36%. Comparing base (33f42b6) to head (1c41347).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files          11       11           
  Lines         603      603           
  Branches      114      114           
=======================================
  Hits          563      563           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . Thnaks. Review it in deep.

@jamacku

This comment was marked as outdated.

@jamacku

This comment was marked as outdated.

@jamacku jamacku merged commit 270f0d1 into sclorg:main Sep 6, 2024
11 checks passed
@jamacku jamacku deleted the filter branch September 6, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tmt_plan_filter is being ignored
2 participants