-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This issue adds plan-filter into TFaGA #223
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 93.27% 93.36% +0.08%
==========================================
Files 11 11
Lines 595 603 +8
Branches 112 114 +2
==========================================
+ Hits 555 563 +8
Misses 40 40 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Petr "Stone" Hracek <[email protected]>
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include short description in commit message
Co-authored-by: Jan Macku <[email protected]>
Co-authored-by: Jan Macku <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
One question, tmt allows for providing several tags with the filter like |
@spetrosi Well as an input we get string, so If you enter string, like you want, we send it to Testing Farm. |
@spetrosi Can you please past link to your plans for an inspiration? |
They are not ready yet, so far I am using a single plan in https://github.com/linux-system-roles/tft-tests/tree/main/plans. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, LGTM
@phracek I am running TFaGA with Warning: Unexpected input(s) 'tmt_plan_filter', valid inputs are ['api_key', 'api_url', 'tf_scope', 'git_url', 'git_ref', 'tmt_plan_regex', 'tmt_context', 'tmt_path', 'compose', 'arch', 'variables', 'secrets', 'tmt_hardware', 'copr', 'copr_artifacts', 'github_token', 'create_issue_comment', 'pull_request_status_name', 'update_pull_request_status', 'environment_settings', 'pipeline_settings', 'create_github_summary', 'timeout', 'repo_owner', 'repo_name', 'pr_number', 'commit_sha'] |
Follow up for sclorg#223
Add plan-filter into TFaGA
Closes: #222