Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This issue adds plan-filter into TFaGA #223

Merged
merged 5 commits into from
Aug 9, 2024
Merged

This issue adds plan-filter into TFaGA #223

merged 5 commits into from
Aug 9, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Aug 8, 2024

Add plan-filter into TFaGA

Closes: #222

@jamacku jamacku added the type: feature New feature or request label Aug 8, 2024
@jamacku jamacku self-requested a review August 8, 2024 13:53
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.36%. Comparing base (56b033b) to head (9f61ef1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   93.27%   93.36%   +0.08%     
==========================================
  Files          11       11              
  Lines         595      603       +8     
  Branches      112      114       +2     
==========================================
+ Hits          555      563       +8     
  Misses         40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phracek

This comment was marked as outdated.

Add plan-filter into TFaGA

Closes: #222

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Aug 8, 2024

[test]

Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include short description in commit message

README.md Outdated Show resolved Hide resolved
src/action.ts Outdated Show resolved Hide resolved
src/action.ts Outdated Show resolved Hide resolved
phracek and others added 3 commits August 9, 2024 09:44
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@spetrosi
Copy link
Contributor

spetrosi commented Aug 9, 2024

One question, tmt allows for providing several tags with the filter like tmt plans ls --filter "tag:mssql,general,postfix".
Will that work with tmt_plan_filter too? I guess if I set tmt_plan_filter: "tag:mssql,general,postfix".

@phracek
Copy link
Member Author

phracek commented Aug 9, 2024

One question, tmt allows for providing several tags with the filter like tmt plans ls --filter "tag:mssql,general,postfix". Will that work with tmt_plan_filter too? I guess if I set tmt_plan_filter: "tag:mssql,general,postfix".

@spetrosi Well as an input we get string, so If you enter string, like you want, we send it to Testing Farm.
As soon as this pull request is merged into main, can you please test it and provide a feedback. Thanks

@phracek
Copy link
Member Author

phracek commented Aug 9, 2024

@spetrosi Can you please past link to your plans for an inspiration?

@spetrosi
Copy link
Contributor

spetrosi commented Aug 9, 2024

They are not ready yet, so far I am using a single plan in https://github.com/linux-system-roles/tft-tests/tree/main/plans.
For testing how tmt filters, I copied this plan and applied different tags to each copy. BTW tmt also supports setting several tags which is good.

Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, LGTM

@jamacku jamacku merged commit c10d1c7 into main Aug 9, 2024
7 checks passed
@jamacku jamacku deleted the plan-filter branch August 9, 2024 15:17
@spetrosi
Copy link
Contributor

spetrosi commented Aug 26, 2024

@phracek I am running TFaGA with tmt_plan_filter: "tag:general,postfix", the workflow returns a warning:

Warning: Unexpected input(s) 'tmt_plan_filter', valid inputs are ['api_key', 'api_url', 'tf_scope', 'git_url', 'git_ref', 'tmt_plan_regex', 'tmt_context', 'tmt_path', 'compose', 'arch', 'variables', 'secrets', 'tmt_hardware', 'copr', 'copr_artifacts', 'github_token', 'create_issue_comment', 'pull_request_status_name', 'update_pull_request_status', 'environment_settings', 'pipeline_settings', 'create_github_summary', 'timeout', 'repo_owner', 'repo_name', 'pr_number', 'commit_sha']
It's in https://github.com/spetrosi/postfix/actions/runs/10561612203/job/29257740325

spetrosi added a commit to spetrosi/testing-farm-as-github-action that referenced this pull request Aug 27, 2024
jamacku pushed a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ability to specify plan-filter
3 participants