Support building and testing NodeJS on RHEL10 host #471

phracek · 2025-01-22T11:51:55Z

This pull request supports building and testing nodejs-container on RHEL10 host.

It is separated into two commits:

the first adds Dockerfile.rhel10 files
second commit updates README.md files

…EL10 host Signed-off-by: Petr "Stone" Hracek <[email protected]>

Signed-off-by: Petr "Stone" Hracek <[email protected]>

github-actions · 2025-01-22T11:52:36Z

Pull Request validation

Failed

🔴 Failed or pending statuses - Testing Farm - CentOS Stream 10 - 22[error],Testing Farm - CentOS Stream 9 - 20[error],Testing Farm - RHEL10 - 22[error]

Success

🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

phracek · 2025-01-22T11:53:54Z

Difference between C10S and RHEL10 is:

$  diff -u 22/Dockerfile.c10s 22/Dockerfile.rhel10
--- 22/Dockerfile.c10s  2024-10-17 10:54:46
+++ 22/Dockerfile.rhel10        2025-01-22 12:43:12
@@ -1,4 +1,4 @@
-FROM quay.io/sclorg/s2i-core-c10s:c10s
+FROM ubi10/s2i-core:latest

 # This image provides a Node.JS environment you can use to run your Node.JS
 # applications.
@@ -46,12 +46,12 @@
       com.redhat.deployments-dir="${APP_ROOT}/src" \
       com.redhat.dev-mode.port="DEBUG_PORT:5858" \
       com.redhat.component="${NAME}-${NODEJS_VERSION}-container" \
-      name="sclorg/$NAME-$NODEJS_VERSION-c10s" \
+      name="ubi10/$NAME-$NODEJS_VERSION" \
       version="1" \
       com.redhat.license_terms="https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI" \
       maintainer="SoftwareCollections.org <[email protected]>" \
       help="For more information visit https://github.com/sclorg/s2i-nodejs-container" \
-      usage="s2i build <SOURCE-REPOSITORY> quay.io/sclorg/$NAME-$NODEJS_VERSION-c10s:latest <APP-NAME>"
+      usage="s2i build <SOURCE-REPOSITORY> ubi10/$NAME-$NODEJS_VERSION <APP-NAME>"

 # Package libatomic_ops was removed
 RUN INSTALL_PKGS="make gcc gcc-c++ git openssl-devel nodejs nodejs-nodemon nodejs-npm nss_wrapper-libs which" && \

Difference between RHEL9 and RHEL10 is:

$ diff -u 22/Dockerfile.rhel9 22/Dockerfile.rhel10
--- 22/Dockerfile.rhel9 2024-10-15 09:42:51
+++ 22/Dockerfile.rhel10        2025-01-22 12:43:12
@@ -1,4 +1,4 @@
-FROM ubi9/s2i-core:1
+FROM ubi10/s2i-core:latest

 # This image provides a Node.JS environment you can use to run your Node.JS
 # applications.
@@ -21,7 +21,7 @@
     NAME=nodejs \
     NPM_CONFIG_PREFIX=$HOME/.npm-global \
     PATH=$HOME/node_modules/.bin/:$HOME/.npm-global/bin/:$PATH \
-    CNB_STACK_ID=com.redhat.stacks.ubi9-nodejs-20 \
+    CNB_STACK_ID=com.redhat.stacks.c10s-nodejs-22 \
     CNB_USER_ID=1001 \
     CNB_GROUP_ID=0

@@ -41,24 +41,25 @@
       io.openshift.tags="builder,$NAME,${NAME}${NODEJS_VERSION}" \
       io.openshift.s2i.scripts-url="image:///usr/libexec/s2i" \
       io.s2i.scripts-url="image:///usr/libexec/s2i" \
-      io.buildpacks.stack.id="com.redhat.stacks.ubi9-nodejs-20" \
+      io.buildpacks.stack.id="com.redhat.stacks.c10s-nodejs-22" \
       com.redhat.dev-mode="DEV_MODE:false" \
       com.redhat.deployments-dir="${APP_ROOT}/src" \
       com.redhat.dev-mode.port="DEBUG_PORT:5858" \
       com.redhat.component="${NAME}-${NODEJS_VERSION}-container" \
-      name="ubi9/$NAME-$NODEJS_VERSION" \
+      name="ubi10/$NAME-$NODEJS_VERSION" \
       version="1" \
       com.redhat.license_terms="https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI" \
       maintainer="SoftwareCollections.org <[email protected]>" \
       help="For more information visit https://github.com/sclorg/s2i-nodejs-container" \
-      usage="s2i build <SOURCE-REPOSITORY> ubi9/$NAME-$NODEJS_VERSION:latest <APP-NAME>"
+      usage="s2i build <SOURCE-REPOSITORY> ubi10/$NAME-$NODEJS_VERSION <APP-NAME>"

-RUN dnf -y module enable nodejs:$NODEJS_VERSION && \
-    MODULE_DEPS="make gcc gcc-c++ git openssl-devel" && \
-    INSTALL_PKGS="$MODULE_DEPS nodejs npm nodejs-nodemon nss_wrapper-libs which" && \
-    ln -s /usr/lib/node_modules/nodemon/bin/nodemon.js /usr/bin/nodemon && \
+# Package libatomic_ops was removed
+RUN INSTALL_PKGS="make gcc gcc-c++ git openssl-devel nodejs nodejs-nodemon nodejs-npm nss_wrapper-libs which" && \
     dnf install -y --setopt=tsflags=nodocs $INSTALL_PKGS && \
     rpm -V $INSTALL_PKGS && \
+    rm /usr/bin/node && ln -s /usr/bin/node-$NODEJS_VERSION /usr/bin/node && \
+    rm /usr/bin/npm && ln -s /usr/bin/npm-$NODEJS_VERSION /usr/bin/npm && \
+    rm /usr/bin/npx && ln -s /usr/bin/npx-$NODEJS_VERSION /usr/bin/npx && \
     node -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" && \
     dnf -y clean all --enablerepo='*'

phracek · 2025-01-22T11:53:58Z

[test]

phracek · 2025-01-22T11:55:14Z

Difference between C10S and RHEL10 is:

$ diff -u 22-minimal/Dockerfile.c10s 22-minimal/Dockerfile.rhel10
--- 22-minimal/Dockerfile.c10s  2024-10-15 09:42:51
+++ 22-minimal/Dockerfile.rhel10        2025-01-22 12:49:40
@@ -1,4 +1,4 @@
-FROM quay.io/sclorg/s2i-core-c10s
+FROM ubi10/ubi-minimal

 EXPOSE 8080

@@ -43,16 +43,19 @@
       com.redhat.deployments-dir="${APP_ROOT}/src" \
       com.redhat.dev-mode.port="DEBUG_PORT:5858" \
       com.redhat.component="${NAME}-${NODEJS_VERSION}-minimal-container" \
-      name="sclorg/$NAME-$NODEJS_VERSION-minimal-c10s" \
+      name="ubi9/$NAME-$NODEJS_VERSION-minimal" \
       version="1" \
+      com.redhat.license_terms="https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI" \
       maintainer="SoftwareCollections.org <[email protected]>" \
       help="For more information visit https://github.com/sclorg/s2i-nodejs-container"

 # nodejs-full-i18n is included for error strings
-RUN INSTALL_PKGS="nodejs$NODEJS_VERSION nodejs-nodemon nodejs$NODEJS_VERSION-full-i18n npm findutils tar which" && \
-    dnf -y --nodocs --setopt=install_weak_deps=0 install $INSTALL_PKGS && \
-    node-22 -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" && \
-    dnf clean all && \
+RUN INSTALL_PKGS="nodejs nodejs-nodemon nodejs-full-i18n npm findutils tar which" && \
+    microdnf -y module disable nodejs && \
+    microdnf -y module enable nodejs:$NODEJS_VERSION && \
+    microdnf -y --nodocs --setopt=install_weak_deps=0 install $INSTALL_PKGS && \
+    node -v | grep -qe "^v$NODEJS_VERSION\." && echo "Found VERSION $NODEJS_VERSION" && \
+    microdnf clean all && \
     rm -rf /mnt/rootfs/var/cache/* /mnt/rootfs/var/log/dnf* /mnt/rootfs/var/log/yum.*

 COPY ./s2i/bin/ /usr/libexec/s2i

Difference between 22-minimal RHEL9 and RHEL10 is:

$  diff -u 22-minimal/Dockerfile.rhel9 22-minimal/Dockerfile.rhel10
--- 22-minimal/Dockerfile.rhel9 2024-10-15 09:42:51
+++ 22-minimal/Dockerfile.rhel10        2025-01-22 12:49:40
@@ -1,4 +1,4 @@
-FROM ubi9/ubi-minimal
+FROM ubi10/ubi-minimal

 EXPOSE 8080

@@ -16,7 +16,7 @@
     # The $HOME is not set by default, but some applications need this variable
     HOME=/opt/app-root/src \
     NPM_RUN=start \
-    PLATFORM="el9" \
+    PLATFORM="el10" \
     NODEJS_VERSION=22 \
     NPM_RUN=start \
     NAME=nodejs

github-actions · 2025-01-22T12:01:57Z

Testing Farm results

name	compose	arch	status	started (UTC)	time	logs
CentOS Stream 9 - 20-minimal	CentOS-Stream-9	x86_64	✅ passed	27.01.2025 15:55:37	10min 14s	test pipeline
CentOS Stream 10 - 22-minimal	CentOS-Stream-10	x86_64	✅ passed	27.01.2025 15:55:59	9min 8s	test pipeline
CentOS Stream 10 - 22	CentOS-Stream-10	x86_64	❌ error	28.01.2025 12:20:31	10min 17s	test pipeline
CentOS Stream 9 - 20	CentOS-Stream-9	x86_64	❌ error	28.01.2025 12:20:28	13min 54s	test pipeline
Fedora - 18-minimal	Fedora-latest	x86_64	✅ passed	27.01.2025 15:55:38	11min 57s	test pipeline
Fedora - 20-minimal	Fedora-latest	x86_64	✅ passed	27.01.2025 15:55:38	11min 40s	test pipeline
Fedora - 22-minimal	Fedora-latest	x86_64	✅ passed	27.01.2025 13:51:36	13min 15s	test pipeline
Fedora - 20	Fedora-latest	x86_64	✅ passed	27.01.2025 15:55:40	15min 34s	test pipeline
Fedora - 18	Fedora-latest	x86_64	✅ passed	27.01.2025 15:55:39	12min 58s	test pipeline
RHEL9 - 18-minimal	RHEL-9.4.0-Nightly	x86_64	✅ passed	27.01.2025 15:55:37	17min 31s	test pipeline
RHEL9 - 20-minimal	RHEL-9.4.0-Nightly	x86_64	✅ passed	27.01.2025 15:55:49	15min 52s	test pipeline
Fedora - 22	Fedora-latest	x86_64	✅ passed	27.01.2025 15:55:50	16min 3s	test pipeline
RHEL9 - 18	RHEL-9.4.0-Nightly	x86_64	✅ passed	27.01.2025 15:55:36	16min 42s	test pipeline
RHEL8 - 18-minimal	RHEL-8.10.0-Nightly	x86_64	✅ passed	27.01.2025 15:55:37	19min 23s	test pipeline
RHEL10 - 22	RHEL-10-Nightly	x86_64	❌ error	28.01.2025 12:20:28	18min 36s	test pipeline
RHEL8 - 18	RHEL-8.10.0-Nightly	x86_64	✅ passed	27.01.2025 15:55:37	19min 8s	test pipeline
RHEL8 - 20-minimal	RHEL-8.10.0-Nightly	x86_64	✅ passed	27.01.2025 13:43:29	18min 5s	test pipeline
RHEL9 - 20	RHEL-9.4.0-Nightly	x86_64	✅ passed	27.01.2025 15:55:37	19min 45s	test pipeline
RHEL9 - 22	RHEL-9.4.0-Nightly	x86_64	✅ passed	27.01.2025 15:55:50	19min 16s	test pipeline
RHEL8 - 20	RHEL-8.10.0-Nightly	x86_64	✅ passed	27.01.2025 15:55:49	22min 25s	test pipeline
RHEL10 - 22-minimal	RHEL-10-Nightly	x86_64	✅ passed	27.01.2025 16:09:08	18min 20s	test pipeline
RHEL9 - 22-minimal	RHEL-9.4.0-Nightly	x86_64	✅ passed	27.01.2025 16:09:12	15min 45s	test pipeline

Instead of `ubi10/ubi-minimal` it is `ubi10-minimal` Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2025-01-27T13:19:06Z

Let's re-test after fix base image for NodeJS 22-minimal

[test]

Pull image ubi10/nodejs-22 in case testing container NodeJS-22 minimal Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2025-01-27T15:55:22Z

[test]

phracek · 2025-01-28T12:25:38Z

@lholmquist @pacostas Please take a look at it. Also, Dockerfile differences are present. It should be easy to review.

phracek · 2025-01-28T12:53:51Z

RHEL10 22 failed here:

 [PASSED] for 'hw' test_node_cmd_development_init_wrapper_true (00:00:02)
 [PASSED] for 'hw' test_init_wrapper_false_development (00:00:01)
 [FAILED] for 'binary' test_run_binary_application (00:01:09)
 [PASSED] for 'binary' test_node_cmd_development_init_wrapper_true (00:00:02)

the log is

npm error gyp info spawn args '-f',
npm error gyp info spawn args 'make',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/opt/app-root/src/node_modules/node-rdkafka/build/config.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/usr/lib/node_modules_22/npm/node_modules/node-gyp/addon.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/opt/app-root/src/.cache/node-gyp/22.11.0/include/node/common.gypi',
npm error gyp info spawn args '-Dlibrary=shared_library',
npm error gyp info spawn args '-Dvisibility=default',
npm error gyp info spawn args '-Dnode_root_dir=/opt/app-root/src/.cache/node-gyp/22.11.0',
npm error gyp info spawn args '-Dnode_gyp_dir=/usr/lib/node_modules_22/npm/node_modules/node-gyp',
npm error gyp info spawn args '-Dnode_lib_file=/opt/app-root/src/.cache/node-gyp/22.11.0/<(target_arch)/node.lib',
npm error gyp info spawn args '-Dmodule_root_dir=/opt/app-root/src/node_modules/node-rdkafka',
npm error gyp info spawn args '-Dnode_engine=v8',
npm error gyp info spawn args '--depth=.',
npm error gyp info spawn args '--no-parallel',
npm error gyp info spawn args '--generator-output',
npm error gyp info spawn args 'build',
npm error gyp info spawn args '-Goutput_dir=.'
npm error gyp info spawn args ]
npm error gyp info spawn make
npm error gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm error rdkafka_admin.c: In function 'rd_kafka_UserScramCredentialUpsertion_new':
npm error rdkafka_admin.c:5986:21: error: implicit declaration of function 'RAND_priv_bytes' [-Wimplicit-function-declaration]
npm error  5986 |                 if (RAND_priv_bytes(random_salt, sizeof(random_salt)) == 1) {
npm error       |                     ^~~~~~~~~~~~~~~
npm error make[2]: *** [../mklove/Makefile.base:97: rdkafka_admin.o] Error 1
npm error make[1]: *** [Makefile:27: libs] Error 2
npm error make: *** [deps/librdkafka.target.mk:30: 11a9e3388a67e1ca5c31c1d8da49cb6d2714eb41.intermediate] Error 2
npm error gyp ERR! build error 
npm error gyp ERR! stack Error: `make` failed with exit code: 2
npm error gyp ERR! stack at ChildProcess.<anonymous> (/usr/lib/node_modules_22/npm/node_modules/node-gyp/lib/build.js:216:23)
npm error gyp ERR! System Linux 6.12.0-45.el10.x86_64
npm error gyp ERR! command "/usr/bin/node-22" "/usr/lib/node_modules_22/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm error gyp ERR! cwd /opt/app-root/src/node_modules/node-rdkafka
npm error gyp ERR! node -v v22.11.0
npm error gyp ERR! node-gyp -v v10.2.0
npm error gyp ERR! not ok
npm error A complete log of this run can be found in: /opt/app-root/src/.npm/_logs/2025-01-28T12_37_13_043Z-debug-0.log
Error: building at STEP "RUN /usr/libexec/s2i/assemble": while running runtime: exit status 1
  ERROR: Failed to to build /tmp/tmp.njYCfGu9Ek/Dockerfile.xXH3
Test for image 'ubi10/nodejs-22:1' FAILED (exit code: 1)
Resolved "ubi10/nodejs-22" as an alias (/etc/containers/registries.conf.d/004-tf-shortnames.conf)

hhorak

I've went through the code changes and all look good to me.

phracek added 2 commits January 22, 2025 12:50

Add Dockerfile.rhel10 to building and testing nodejs containers in RH…

ae3aaf9

…EL10 host Signed-off-by: Petr "Stone" Hracek <[email protected]>

Update README.md files with RHEL10 support

a7b1486

Signed-off-by: Petr "Stone" Hracek <[email protected]>

github-actions bot added the pr/missing-review label Jan 22, 2025

github-actions bot added the pr/failing-ci label Jan 22, 2025

Fix base image for nodejs22-monimal.

a7a7736

Instead of `ubi10/ubi-minimal` it is `ubi10-minimal` Signed-off-by: Petr "Stone" Hracek <[email protected]>

Remove module from 22-minimal/Dockerfile.rhel10

065a162

Pull image ubi10/nodejs-22 in case testing container NodeJS-22 minimal Signed-off-by: Petr "Stone" Hracek <[email protected]>

github-actions bot removed the pr/failing-ci label Jan 27, 2025

github-actions bot added the pr/failing-ci label Jan 27, 2025

phracek requested a review from lholmquist January 28, 2025 12:25

hhorak approved these changes Jan 29, 2025

View reviewed changes

github-actions bot removed the pr/missing-review label Jan 29, 2025

phracek added the READY-to-MERGE label Jan 29, 2025

phracek merged commit 00f5433 into master Jan 29, 2025
20 of 23 checks passed

phracek deleted the building_testing_rhel10 branch January 29, 2025 11:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support building and testing NodeJS on RHEL10 host #471

Support building and testing NodeJS on RHEL10 host #471

phracek commented Jan 22, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

phracek commented Jan 22, 2025

phracek commented Jan 22, 2025

phracek commented Jan 22, 2025

github-actions bot commented Jan 22, 2025 •

edited

Loading

phracek commented Jan 27, 2025

phracek commented Jan 27, 2025

phracek commented Jan 28, 2025

phracek commented Jan 28, 2025

hhorak left a comment

Support building and testing NodeJS on RHEL10 host #471

Support building and testing NodeJS on RHEL10 host #471

Conversation

phracek commented Jan 22, 2025 • edited by github-actions bot Loading

github-actions bot commented Jan 22, 2025 • edited Loading

Pull Request validation

Failed

Success

phracek commented Jan 22, 2025

phracek commented Jan 22, 2025

phracek commented Jan 22, 2025

github-actions bot commented Jan 22, 2025 • edited Loading

Testing Farm results

phracek commented Jan 27, 2025

phracek commented Jan 27, 2025

phracek commented Jan 28, 2025

phracek commented Jan 28, 2025

hhorak left a comment

Choose a reason for hiding this comment

phracek commented Jan 22, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading