Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ct_check_testcase_result instead of check_result #457

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Use ct_check_testcase_result instead of check_result #457

merged 1 commit into from
Nov 6, 2024

Conversation

lukaszachy
Copy link
Contributor

@lukaszachy lukaszachy commented Oct 7, 2024 •
edited by github-actions bot
Loading

The ct_check_testcase_result seems to be the right function to use instead of check_result

Fix: #456

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

Pull Request validation

Failed

🔴 Failed or pending statuses - Testing Farm - CentOS Stream 10 - 22[error]
🔴 Review - Missing review from a member (2 required)

Success

🟢 Review - Reviewed by undefined

@phracek
Copy link
Member

phracek commented Oct 8, 2024

[test]

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64✅ passed08.10.2024 09:47:328min 1stest pipeline
Fedora - 22-minimalFedora-latestx86_64✅ passed08.10.2024 09:47:359min 31stest pipeline
CentOS Stream 10 - 22CentOS-Stream-10x86_64❌ failed04.11.2024 08:48:1810min 36stest pipeline
Fedora - 18-minimalFedora-latestx86_64✅ passed08.10.2024 09:47:0811min 49stest pipeline
Fedora - 18Fedora-latestx86_64✅ passed08.10.2024 09:47:0813min 32stest pipeline
Fedora - 22Fedora-latestx86_64✅ passed08.10.2024 09:47:2114min 30stest pipeline
CentOS Stream 9 - 20CentOS-Stream-9x86_64✅ passed08.10.2024 09:47:1316min 48stest pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed08.10.2024 09:47:1819min 15stest pipeline
CentOS Stream 9 - 20-minimalCentOS-Stream-9x86_64✅ passed08.10.2024 09:47:1720min 59stest pipeline
RHEL9 - 18-minimalRHEL-9.4.0-Nightlyx86_64✅ passed08.10.2024 09:47:101h 16min 53stest pipeline
RHEL9 - 18RHEL-9.4.0-Nightlyx86_64✅ passed08.10.2024 09:47:081h 36min 37stest pipeline
RHEL8 - 18-minimalRHEL-8.10.0-Nightlyx86_64✅ passed08.10.2024 09:47:071h 40min 13stest pipeline
RHEL8 - 20RHEL-8.10.0-Nightlyx86_64✅ passed04.11.2024 08:48:2221min 18stest pipeline
RHEL9 - 22-minimalRHEL-9.4.0-Nightlyx86_64✅ passed08.10.2024 09:48:101h 45min 37stest pipeline
RHEL8 - 18RHEL-8.10.0-Nightlyx86_64✅ passed04.11.2024 08:48:1818min 36stest pipeline
RHEL9 - 20RHEL-9.4.0-Nightlyx86_64✅ passed08.10.2024 09:47:111h 48min 40stest pipeline
RHEL9 - 22RHEL-9.4.0-Nightlyx86_64✅ passed08.10.2024 09:47:211h 50min 50stest pipeline
RHEL9 - 20-minimalRHEL-9.4.0-Nightlyx86_64✅ passed08.10.2024 09:47:211h 56min 48stest pipeline
RHEL8 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed08.10.2024 09:47:231h 58min 32stest pipeline

phracek
phracek approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failures are not caused by this pull request. LGTM. Thanks for this fix.

@phracek phracek merged commit 78b23ef into sclorg:master Nov 6, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek approved these changes

Assignees
No one assigned
Labels
pr/failing-ci pr/missing-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test uses check_result which isn't defined
2 participants
@lukaszachy @phracek