Skip to content

Commit

Permalink
Revert "each container in run_change_password_test mounts its own vol…
Browse files Browse the repository at this point in the history
…ume"

This reverts commit 62a0e88.

Creating a new volume directory was actually NOOP, because the variable
volume_options was not updated. What we need to get rid of SELinux
messages that this fix tried to address is to properly shut down
previous container. That will be done in the following commit.

Background:
podman's :Z modificator for volumes works the way that the latest
container run with the same volume directory mounted with :Z modificator
has access, the previous containers are kept running, but access to the
shared directory is suddenly removed. That caused the first instance of
PostgreSQL server to crash with SIGSEGV actually, while triggering some
SELinux error message during that.
  • Loading branch information
hhorak authored and zmiklank committed Jan 6, 2024
1 parent 62a0e88 commit 1567d0e
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions test/run_test
Original file line number Diff line number Diff line change
Expand Up @@ -634,11 +634,6 @@ $volume_options

echo " Changing passwords"

# create separate mounting directory for second container, as selinux does
# not allow two containers accesing one mounting directory if mounted with
# Z option
create_volume_dir || ret=1

DOCKER_ARGS="
-e POSTGRESQL_DATABASE=${database}
-e POSTGRESQL_USER=${user}
Expand Down

0 comments on commit 1567d0e

Please sign in to comment.