Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow building for any specified $OS #351

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

zmiklank
Copy link
Contributor

@zmiklank zmiklank commented Sep 5, 2023

@zmiklank
Copy link
Contributor Author

zmiklank commented Sep 5, 2023

[test]

@zmiklank
Copy link
Contributor Author

zmiklank commented Sep 5, 2023

@phracek Do we still use the *-candidate $OSes? If yes I will rework this PR to work with them. Current proposal supports only standard targets (rhel7, rhel8, fedora, ...) for which the Dockerfiles exist.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement.

See me comment.

build.sh Show resolved Hide resolved
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's get merge it.

@phracek phracek merged commit 19ea464 into sclorg:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build s2i-base and s2i-core containers for more Fedora versions
2 participants