Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to show tags overview in the imagestreams #256

Closed

Conversation

hhorak
Copy link
Member

@hhorak hhorak commented May 27, 2022

It's supposed to be used as simple as this:

ct_os_show_all_image_stream_tags imagestreams/*json
Tags in the image stream imagestreams/postgresql-centos.json:
- latest -> 12-el8
- 13-el7 -> quay.io/centos7/postgresql-13-centos7:latest
- 12-el8 -> docker.io/centos/postgresql-12-centos8:latest
- 12-el7 -> quay.io/centos7/postgresql-12-centos7:latest
- 12 -> quay.io/centos7/postgresql-12-centos7:latest
- 10-el8 -> docker.io/centos/postgresql-10-centos8:latest
- 10-el7 -> quay.io/centos7/postgresql-10-centos7:latest
- 10 -> quay.io/centos7/postgresql-10-centos7:latest
Tags in the image stream imagestreams/postgresql-rhel-aarch64.json:
- latest -> 13-el8
- 13-el8 -> registry.redhat.io/rhel8/postgresql-13:latest
- 12-el8 -> registry.redhat.io/rhel8/postgresql-12:latest
- 10-el8 -> registry.redhat.io/rhel8/postgresql-10:latest
Tags in the image stream imagestreams/postgresql-rhel.json:
- latest -> 13-el8
- 13-el8 -> registry.redhat.io/rhel8/postgresql-13:latest
- 13-el7 -> registry.redhat.io/rhscl/postgresql-13-rhel7:latest
- 12-el8 -> registry.redhat.io/rhel8/postgresql-12:latest
- 12-el7 -> registry.redhat.io/rhscl/postgresql-12-rhel7:latest
- 12 -> registry.redhat.io/rhscl/postgresql-12-rhel7:latest
- 10-el8 -> registry.redhat.io/rhel8/postgresql-10:latest
- 10-el7 -> registry.redhat.io/rhscl/postgresql-10-rhel7:latest
- 10 -> registry.redhat.io/rhscl/postgresql-10-rhel7:latest

file_name="$1"
shift
echo "Tags in the image stream $file_name:"
jq -r '.spec.tags[] | ("- " + .name + " -> " + .from.name)' "$file_name"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to add jq package to Testing Plan or is it in each system?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, this would need to be added

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't think this change is worth adding this dependency, we should rather use python for this to not complicate testing environment more.

@phracek
Copy link
Member

phracek commented May 31, 2022

@hhorak The pull request is fine, but why do we need to show all imagestreams? Do you have any use-case? E.g. There are missing versions that are currently supported.

What about adding this functionality directly into https://github.com/sclorg/container-common-scripts/blob/master/check_imagestreams.py. I guess this print will be used only in the case of [test-openshift] or [test-all] use case.

@hhorak hhorak marked this pull request as draft July 1, 2022 08:02
@hhorak
Copy link
Member Author

hhorak commented Jul 1, 2022

What about adding this functionality directly into https://github.com/sclorg/container-common-scripts/blob/master/check_imagestreams.py. I guess this print will be used only in the case of [test-openshift] or [test-all] use case.

Good idea, I forgot we have a script for this already. Being it python, it also solves the problem with jq dependency.

phracek added a commit that referenced this pull request May 27, 2024
This fixes PR #256

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member

phracek commented May 27, 2024

This pull request is replaced by #372

phracek added a commit that referenced this pull request May 28, 2024
This fixes PR #256

Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek added a commit that referenced this pull request May 28, 2024
This fixes PR #256

Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek added a commit that referenced this pull request May 28, 2024
New Python function is created so the imagestreams
are shown always.

This fixes PR #256

Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek added a commit that referenced this pull request May 28, 2024
New Python function is created so the imagestreams
are shown always.

This fixes PR #256

Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek added a commit that referenced this pull request Jun 3, 2024
New Python function is created so the imagestreams
are shown always.

This fixes PR #256

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member

phracek commented Jun 3, 2024

Closing. It was implemented by #372

@phracek phracek closed this Jun 3, 2024
phracek added a commit to zmiklank/container-common-scripts that referenced this pull request Jun 5, 2024
New Python function is created so the imagestreams
are shown always.

This fixes PR sclorg#256

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants