-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to show tags overview in the imagestreams #256
Conversation
file_name="$1" | ||
shift | ||
echo "Tags in the image stream $file_name:" | ||
jq -r '.spec.tags[] | ("- " + .name + " -> " + .from.name)' "$file_name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to add jq
package to Testing Plan or is it in each system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, this would need to be added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don't think this change is worth adding this dependency, we should rather use python for this to not complicate testing environment more.
@hhorak The pull request is fine, but why do we need to show all imagestreams? Do you have any use-case? E.g. There are missing versions that are currently supported. What about adding this functionality directly into https://github.com/sclorg/container-common-scripts/blob/master/check_imagestreams.py. I guess this print will be used only in the case of [test-openshift] or [test-all] use case. |
Good idea, I forgot we have a script for this already. Being it python, it also solves the problem with |
This fixes PR #256 Signed-off-by: Petr "Stone" Hracek <[email protected]>
This pull request is replaced by #372 |
This fixes PR #256 Signed-off-by: Petr "Stone" Hracek <[email protected]>
This fixes PR #256 Signed-off-by: Petr "Stone" Hracek <[email protected]>
New Python function is created so the imagestreams are shown always. This fixes PR #256 Signed-off-by: Petr "Stone" Hracek <[email protected]>
New Python function is created so the imagestreams are shown always. This fixes PR #256 Signed-off-by: Petr "Stone" Hracek <[email protected]>
New Python function is created so the imagestreams are shown always. This fixes PR #256 Signed-off-by: Petr "Stone" Hracek <[email protected]>
Closing. It was implemented by #372 |
New Python function is created so the imagestreams are shown always. This fixes PR sclorg#256 Signed-off-by: Petr "Stone" Hracek <[email protected]>
It's supposed to be used as simple as this: