Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to omit default tags of built image #29

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Add possibility to omit default tags of built image #29

merged 1 commit into from
Sep 27, 2023

Conversation

zmiklank
Copy link
Contributor

phracek
phracek requested changes Sep 21, 2023
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@zmiklank zmiklank marked this pull request as ready for review September 21, 2023 11:58
@zmiklank zmiklank changed the title WIP: Add possibility to omit default tags of built image Add possibility to omit default tags of built image Sep 21, 2023
frenzymadness
frenzymadness approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the action as a whole but I think this change supports the use case we need for building more than one Fedora image at the same time.

@zmiklank zmiklank merged commit 7e00370 into sclorg:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek requested changes

@frenzymadness frenzymadness frenzymadness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmiklank @phracek @frenzymadness