Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two ascii art squirrels. #74

Merged
merged 2 commits into from
Sep 3, 2019
Merged

Conversation

marionlouveaux
Copy link
Contributor

Description

Hi,
I added two ascii art squirrels. I drew these squirrels myself using this Flickr image as a background template: https://www.flickr.com/photos/hedera_baltica/44806157514/in/photostream/
I made sure package passes checks and tests.

Related Issue

No related issue

Example

@sckott
Copy link
Owner

sckott commented Aug 30, 2019

thanks @marionlouveaux ! Having a look

Copy link
Owner

@sckott sckott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. a few things:

  • please change your initials to ML instead of %ML% - or is there a good reason for the use of %?
  • just checking: the only difference btw the two is the eye?

@marionlouveaux
Copy link
Contributor Author

Hi,
Thanks for looking at it!
I changed my initials to ML.
Yes, the only difference between the two is the eye.

@sckott sckott added this to the v0.8 milestone Sep 3, 2019
@sckott
Copy link
Owner

sckott commented Sep 3, 2019

thanks @marionlouveaux looks good!

@sckott
Copy link
Owner

sckott commented Sep 3, 2019

thanks for your contribution. i'll add your name to the pkg after merging

@sckott sckott merged commit 7c8467e into sckott:master Sep 3, 2019
@marionlouveaux
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants