Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add monkey 🐒 #47

Merged
merged 4 commits into from
Dec 8, 2016
Merged

add monkey 🐒 #47

merged 4 commits into from
Dec 8, 2016

Conversation

LucyMcGowan
Copy link
Contributor

I added a monkey -- I feel like this was a very small contribution, but I am happy to update the contributors list if you prefer.

@sckott
Copy link
Owner

sckott commented Dec 8, 2016

awesome! plz do update the contributors list with your name!

@LucyMcGowan
Copy link
Contributor Author

I changed the readme & description, but it seems to have failed 👆🏼, let me know if there is something I should change. thanks!

@sckott
Copy link
Owner

sckott commented Dec 8, 2016

there's a minor thing in the DESCRIPTION file. R doesn't like this newline here https://github.com/LucyMcGowan/cowsay/blob/master/DESCRIPTION#L18 - remove that and push again

@LucyMcGowan
Copy link
Contributor Author

awesome, updated. thank you!

@sckott
Copy link
Owner

sckott commented Dec 8, 2016

awesome, nice work @LucyMcGowan

thanks so so much for your contribution!

@sckott sckott merged commit 9f47d16 into sckott:master Dec 8, 2016
@sckott sckott modified the milestone: v0.5 Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@LucyMcGowan @sckott