Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add CircleCI API token to fix html preview link #18292

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

rgommers
Copy link
Member

Note that this has to be a personal token, not an org token.

Note that this has to be a personal token, not an org token.

[skip azp] [skip cirrus]
@rgommers rgommers added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Apr 13, 2023
@rgommers
Copy link
Member Author

Hmm the preview itself didn't run - does anyone know what's up with that, was it disabled manually or by another PR? @tupui or @melissawm maybe?

Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf!

@tupui tupui merged commit 49d4608 into scipy:main Apr 13, 2023
@tupui tupui added this to the 1.11.0 milestone Apr 13, 2023
@tupui
Copy link
Member

tupui commented Apr 13, 2023

Sorry the webpage was cached and did not see your message. Let's see if this was due to not being on main.

To you question, I did not touch anything there and don't see a PR that would do that from yesterday.

@rgommers rgommers deleted the circleci-fix branch April 13, 2023 11:05
@tupui
Copy link
Member

tupui commented Apr 13, 2023

Ok all looks good on main the CI ran and we do see the correct redirect 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants