Refactor includes #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to allow other projects to include files from libsnark without explicitly putting the root of libsnark source into their include path.
This removes the need to add libff's source root to our include path, and makes includes clearer and less ambiguous.
See previous commit for justification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
converts the paths in all local includes (i.e. those including files from within libsnark) from absolute to relative (see pull request 7 in libff for justification)
converts all libff/libfqfft includes from local to system-style (e.g.
#include "common/utils.hpp"→#include <libff/common/utils.hpp>) to make it explicit and unambiguous when files from an external library are being included.This pull request (as well as the accompanying ones in libff and libfqfft) was largely generated using a Python script.