-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pipelines #834
Fix pipelines #834
Conversation
mmghannam
commented
Apr 2, 2024
•
edited
Loading
edited
- Use backwards compatible type hints.
- Install bison in macos pipeline.
- Install locales needed by tests in ubuntu integration test.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #834 +/- ##
==========================================
- Coverage 52.30% 52.29% -0.02%
==========================================
Files 19 19
Lines 3904 3905 +1
==========================================
Hits 2042 2042
- Misses 1862 1863 +1 ☔ View full report in Codecov by Sentry. |
Should be working now with these changes https://github.com/scipopt/PySCIPOpt/actions/runs/8528377932?pr=834 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, Mo! Genuine question, why do you prefer typing List to regular list?
I don't 😄 It's just that it works with older python versions. |