Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropEvent bug #828

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Fix dropEvent bug #828

merged 3 commits into from
Apr 1, 2024

Conversation

Joao-Dionisio
Copy link
Collaborator

@Joao-Dionisio Joao-Dionisio commented Mar 24, 2024

It seems to fix the problem with Issue #820, but the underlying cause might still be there. Me and Mo couldn't figure out why self.model was deleted when the call to dropEvent is made.

Fix #820.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 51.85%. Comparing base (9e16f75) to head (03fec73).

Files Patch % Lines
src/pyscipopt/scip.pxi 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
- Coverage   52.18%   51.85%   -0.34%     
==========================================
  Files          18       18              
  Lines        3888     3890       +2     
==========================================
- Hits         2029     2017      -12     
- Misses       1859     1873      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Joao-Dionisio Joao-Dionisio merged commit 1f858fe into master Apr 1, 2024
1 of 3 checks passed
@Joao-Dionisio Joao-Dionisio deleted the dropEventFix branch January 16, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The issue to use Eventhdlr
2 participants