Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize Python metadata #791

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 19, 2024

Moving them to pyproject.toml

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 52.69%. Comparing base (e838781) to head (f88f507).

Files Patch % Lines
src/pyscipopt/_version.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
- Coverage   52.70%   52.69%   -0.02%     
==========================================
  Files          16       17       +1     
  Lines        3808     3809       +1     
==========================================
  Hits         2007     2007              
- Misses       1801     1802       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mmghannam mmghannam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mkoeppe! this looks so much better. I fixed the conflict with your other PR (by removing the cython<3 requirement). Should be good to merge once the tests pass.

@mmghannam mmghannam merged commit 5a166be into scipopt:master Feb 25, 2024
1 of 3 checks passed
@mkoeppe mkoeppe deleted the pyproject_metadata branch February 25, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants