Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hasPrimalRay, getPrimalRay, getPrimalRayVal #743

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

Joao-Dionisio
Copy link
Collaborator

No description provided.

@Joao-Dionisio Joao-Dionisio changed the title Add tests and CHANGELOG Add getPrimalRay, getPrimalRayVal Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #743 (5e8774f) into master (f95846e) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
+ Coverage   58.79%   58.92%   +0.13%     
==========================================
  Files          16       16              
  Lines        3150     3160      +10     
==========================================
+ Hits         1852     1862      +10     
  Misses       1298     1298              
Files Coverage Δ
src/pyscipopt/scip.pxi 55.78% <100.00%> (+0.24%) ⬆️

@Joao-Dionisio Joao-Dionisio changed the title Add getPrimalRay, getPrimalRayVal Add hasPrimalRay, getPrimalRay, getPrimalRayVal Oct 28, 2023
@mmghannam mmghannam self-assigned this Oct 30, 2023
Copy link
Member

@mmghannam mmghannam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks João! I added some minor comments.

src/pyscipopt/scip.pxi Show resolved Hide resolved
tests/test_solution.py Show resolved Hide resolved
src/pyscipopt/scip.pxi Show resolved Hide resolved
@mmghannam mmghannam merged commit 63db0c8 into scipopt:master Nov 3, 2023
17 checks passed
@Joao-Dionisio Joao-Dionisio deleted the getPrimalRay branch November 3, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants