log: Clean log package & move config to log package #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up the public API of the log package and moves the log config from env to the log package. Breaking: this commit changes the config format to snake_case. Furthermore the APIs change: - The toml key for logging config is changed from `logging` to `log` - `env.SetupLogging` is replaced by `log.Setup` - `env.Logging` is replaced by `log.Config` - `util.GetDebugID()` is now `log.NewDebugID()` - `log.RandId()` is removed and `log.NewDebugID()` should be used instead - The log packages no longer provides flag setup, whoever wants to use flags should define them in main. Fixes scionproto#3594
karampok
suggested changes
Feb 24, 2020
There was a problem hiding this comment.
Reviewed 100 of 100 files at r1, 1 of 5 files at r2.
Reviewable status: 97 of 101 files reviewed, 1 unresolved discussion (waiting on @karampok and @lukedirtwalker)
go/lib/log/logtest/config.go, line 1 at r1 (raw file):
// Copyright 2019 Anapaya Systems
2020
lukedirtwalker
commented
Feb 24, 2020
There was a problem hiding this comment.
Reviewable status: 97 of 101 files reviewed, 1 unresolved discussion (waiting on @karampok)
go/lib/log/logtest/config.go, line 1 at r1 (raw file):
Previously, karampok (Konstantinos) wrote…
2020
Done.
karampok
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
Reviewed 4 of 5 files at r2, 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
lukedirtwalker
added
the
i/breaking change
stygerma
pushed a commit
to stygerma/scion
that referenced
this pull request
Mar 26, 2020
Cleans up the public API of the log package and moves the log config from env to the log package. Breaking: this commit changes the config format to snake_case. Furthermore the APIs change: - The toml key for logging config is changed from `logging` to `log` - `env.SetupLogging` is replaced by `log.Setup` - `env.Logging` is replaced by `log.Config` - `util.GetDebugID()` is now `log.NewDebugID()` - `log.RandId()` is removed and `log.NewDebugID()` should be used instead - The log packages no longer provides flag setup, whoever wants to use flags should define them in main. Fixes scionproto#3594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the public API of the log package and
moves the log config from env to the log package.
Breaking: this commit changes the config format to snake_case.
Furthermore the APIs change:
loggingtologenv.SetupLoggingis replaced bylog.Setupenv.Loggingis replaced bylog.Configutil.GetDebugID()is nowlog.NewDebugID()log.RandId()is removed andlog.NewDebugID()should be used insteadFixes #3594
This change is