-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix remote caching #3633
ci: Fix remote caching #3633
Conversation
f9bdb51
to
46a04c3
Compare
46a04c3
to
6a55da6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @karampok and @lukedirtwalker)
.bazelrc_ci, line 1 at r1 (raw file):
build --disk_cache= --remote_cache=grpc://localhost:9092
I would like a link to the documentation
or maybe
build --disc_cash=this/has/to/invalid/so/remote/cache/to/work
:)
otherwise someone will just see this as a mistake and silently fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @karampok)
.bazelrc_ci, line 1 at r1 (raw file):
Previously, karampok (Konstantinos) wrote…
I would like a link to the documentation
or maybe
build --disc_cash=this/has/to/invalid/so/remote/cache/to/work
:)otherwise someone will just see this as a mistake and silently fix it
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
74a6435
to
106d647
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved
106d647
to
fc03be2
Compare
It seems that if
--disk-cache
with a valid location is present, bazel will ignore--remote-cache
.Thus we must override
--disk-cache
to the empty value in the.bazelrc_ci
file,so that on the CI only the remote cache is used.
Also switch to using the bazel cache via grpc.
The problem was introduced by #3591
This change is