Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix remote caching #3633

Merged

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Jan 22, 2020

It seems that if --disk-cache with a valid location is present, bazel will ignore --remote-cache.
Thus we must override --disk-cache to the empty value in the .bazelrc_ci file,
so that on the CI only the remote cache is used.

Also switch to using the bazel cache via grpc.

The problem was introduced by #3591

This change is Reviewable

@lukedirtwalker lukedirtwalker force-pushed the pubInvestigeBazelCache branch 5 times, most recently from f9bdb51 to 46a04c3 Compare January 23, 2020 08:06
@lukedirtwalker lukedirtwalker changed the title ci: Investigate remote cache ci: Fix remote caching Jan 23, 2020
@lukedirtwalker lukedirtwalker marked this pull request as ready for review January 23, 2020 08:16
Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @karampok and @lukedirtwalker)


.bazelrc_ci, line 1 at r1 (raw file):

build --disk_cache= --remote_cache=grpc://localhost:9092

I would like a link to the documentation
or maybe
build --disc_cash=this/has/to/invalid/so/remote/cache/to/work :)

otherwise someone will just see this as a mistake and silently fix it

Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @karampok)


.bazelrc_ci, line 1 at r1 (raw file):

Previously, karampok (Konstantinos) wrote…

I would like a link to the documentation
or maybe
build --disc_cash=this/has/to/invalid/so/remote/cache/to/work :)

otherwise someone will just see this as a mistake and silently fix it

Done.

Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit ad7f828 into scionproto:master Jan 24, 2020
@lukedirtwalker lukedirtwalker deleted the pubInvestigeBazelCache branch January 24, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants