Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add bazel timestamps and enable local run of the pipeline #3589

Merged
merged 4 commits into from
Jan 9, 2020

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Jan 8, 2020

This PR adds timestamps in bazel and hardcodes the test-artifact folder in order to
enable local run. Now everything runs locally apart from acceptance test that require
some sudo interactive action.

Contributes #3286

This change is Reviewable

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karampok)

a discussion (no related file):
please add it to .bazelrc_ci as well. For now the files are both respected, but it might not be the case in the future.


@karampok karampok force-pushed the pub-bazel-timestamps branch from 048c130 to d0939e6 Compare January 9, 2020 08:04
Copy link
Contributor Author

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

a discussion (no related file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

please add it to .bazelrc_ci as well. For now the files are both respected, but it might not be the case in the future.

Done.


Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karampok karampok changed the title ci: add timestamps in bazel steps CI: add bazel timestamps and enable local run of the pipeline Jan 9, 2020
@karampok karampok force-pushed the pub-bazel-timestamps branch from ee9a714 to 2494f22 Compare January 9, 2020 08:58
@karampok karampok merged commit 150f608 into scionproto:master Jan 9, 2020
@karampok karampok deleted the pub-bazel-timestamps branch January 9, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants