TrustStore: Add chain push handler

[oncilla]

Add certificate chain push handler to the trust store.
Currently, unit tests are missing. Edited by @scrye: added unit tests.

fixes #3486

---

This change is 

[oncilla]

Reviewed 1 of 2 files at r1, 4 of 4 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @scrye)

---

go/lib/infra/modules/trust/v2/handlers.go, line 36 at r2 (raw file):

// HandlerTimeout is the lifetime of the handlers.
const HandlerTimeout = 3 * time.Second

from @lukedirtwalker review. Drop this. The default handler timeout should be enough.

---

go/lib/infra/modules/trust/v2/handlers.go, line 45 at r2 (raw file):

func (h *chainPushHandler) Handle() *infra.HandlerResult {
	if h.request == nil {

log this as an error?

---

go/lib/infra/modules/trust/v2/handlers.go, line 63 at r2 (raw file):

	rw, ok := infra.ResponseWriterFromContext(h.request.Context())
	if !ok {
		logger.Warn("[TrustStore:chainPushHandler] Unable to service request, no Messenger found")

s/Messenger/ResponseWriter

[scrye]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @oncilla)

---

go/lib/infra/modules/trust/v2/handlers.go, line 45 at r2 (raw file):

Previously, Oncilla wrote…

log this as an error?

Log to package then? There's no context available to extract the proper logger yet.

[oncilla]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @scrye)

---

go/lib/infra/modules/trust/v2/handlers.go, line 45 at r2 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Log to package then? There's no context available to extract the proper logger yet.

IMO, yes.

[scrye]

Reviewable status: 3 of 5 files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker and @oncilla)

---

go/lib/infra/modules/trust/v2/handlers.go, line 36 at r2 (raw file):

Previously, Oncilla wrote…

from @lukedirtwalker review. Drop this. The default handler timeout should be enough.

Done.

---

go/lib/infra/modules/trust/v2/handlers.go, line 45 at r2 (raw file):

Previously, Oncilla wrote…

IMO, yes.

Done.

[oncilla]

Reviewed 1 of 2 files at r3.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @oncilla)

[scrye]

Reviewed 1 of 2 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)

---

go/lib/infra/modules/trust/v2/handlers.go, line 63 at r2 (raw file):

Previously, Oncilla wrote…

s/Messenger/ResponseWriter

Done.

[oncilla]

Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved

[oncilla]

Reviewable status: all files reviewed, 1 unresolved discussion

---

go/lib/infra/modules/trust/v2/handlers.go, line 64 at r4 (raw file):

		return infra.MetricsErrInternal
	}
	subCtx, cancelF := context.WithTimeout(h.request.Context(), messenger.DefaultHandlerTimeout)

you don't need a subctx

[scrye]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)

---

go/lib/infra/modules/trust/v2/handlers.go, line 64 at r4 (raw file):

Previously, Oncilla wrote…

you don't need a subctx

Done.

[oncilla]

Reviewed 1 of 1 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved