Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use neigh_ia label name. #3354

Merged
merged 3 commits into from
Nov 11, 2019
Merged

Conversation

kormat
Copy link
Contributor

@kormat kormat commented Nov 11, 2019

This change is Reviewable

@kormat kormat requested a review from karampok November 11, 2019 11:14
Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kormat)


go/lib/prom/prom.go, line 37 at r1 (raw file):

	// LabelDst is the label for the destination.
	LabelDst = "dst"
	// LabelNeighIA is label for the neighbouring IA.

The IA should explain what stands for.

Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kormat)

Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kormat kormat merged commit 0676496 into scionproto:master Nov 11, 2019
@kormat kormat deleted the neigh_ia branch November 11, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants