Use serrors.New instead of common.NewBasicError #3175
Conversation
lukedirtwalker
force-pushed
the
pubNewErrorApproach3
branch
from
14e65a1 to
8a4477c
Compare
There was a problem hiding this comment.
Reviewed 165 of 165 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)
go/lib/infra/modules/itopo/itopo.go.orig, line 1 at r1 (raw file):
// Copyright 2018 ETH Zurich
remove
go/proto/cert_mgmt.capnp.go, line 7 at r1 (raw file):
import ( strconv "strconv"
ha, why does this differ?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)
go/lib/infra/modules/itopo/itopo.go.orig, line 1 at r1 (raw file):
Previously, Oncilla wrote…
remove
Done.
go/proto/cert_mgmt.capnp.go, line 7 at r1 (raw file):
Previously, Oncilla wrote…
ha, why does this differ?
I don't know, but it seems to be needed. otherwise the build fails :man-shrugging: ?
There was a problem hiding this comment.
Reviewed 1 of 9 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
go/proto/cert_mgmt.capnp.go, line 7 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
I don't know, but it seems to be needed. otherwise the build fails :man-shrugging: ?
what build fails?
There was a problem hiding this comment.
Reviewed 2 of 9 files at r2.
Reviewable status:
go/proto/cert_mgmt.capnp.go, line 7 at r1 (raw file):
Previously, Oncilla wrote…
what build fails?
Ah, we check that stuff is consistent in CI.
My question was rather, why did it change in your version. Maybe you use a different version of capnp genrerator?
There was a problem hiding this comment.
Reviewable status:
for simple errors without additional wrapping/context.
This PR was generated by replacing `common.NewBasicError\(("[^"]+"), nil\)`
with `serrors.New($1)` and running goimports afterwards.
lukedirtwalker
force-pushed
the
pubNewErrorApproach3
branch
from
4b73098 to
4945f05
Compare
There was a problem hiding this comment.
Reviewed 4 of 4 files at r3.
Reviewable status:
for simple errors without additional wrapping/context.
This PR was generated by replacing
common.NewBasicError\(("[^"]+"), nil\)with
serrors.New($1)and running goimports afterwards.This change is