PS,SD: Use revocations from SegReply to invalidate NextQuery #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
force-pushed
the
pubFixRevocationHandling
branch
from
a33117a to
5696438
Compare
lukedirtwalker
changed the title
oncilla
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
oncilla
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Reviewable status:
lukedirtwalker
force-pushed
the
pubFixRevocationHandling
branch
from
5ef6c77 to
b4ce079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PS and SD we invalidate the NextQuery for all segments that have received a revocation. But currently we only do this for explicit revocations that come in as Revocation message, we should also do it for revocations that we receive in a SegReply from another PS.
This commit also invalidates NextQuery cache for revocations received in the SegReply.
Fixes #3057
This change is