segfetcher: Improve logging / documentation

[lukedirtwalker]

This change is 

[oncilla]

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)

---

go/lib/infra/modules/segfetcher/fetcher.go, line 113 at r1 (raw file):

		}
		if i > 3 {
			log.FromCtx(ctx).Error("No convergence in looking up", "i", i)

"No convergence in lookup", "iteration", i+1

---

go/path_srv/internal/segreq/handler.go, line 89 at r1 (raw file):

		},
	}
	err = rw.SendSegReply(ctx, reply)

collapse in if statement

[lukedirtwalker]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)

---

go/lib/infra/modules/segfetcher/fetcher.go, line 113 at r1 (raw file):

Previously, Oncilla wrote…

"No convergence in lookup", "iteration", i+1

Done.

---

go/path_srv/internal/segreq/handler.go, line 89 at r1 (raw file):

Previously, Oncilla wrote…

collapse in if statement

Done.

[oncilla]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[oncilla]

Reviewable status: complete! all files reviewed, all discussions resolved