Add test to check that all feature flags are boolean

[sustrik]

This change is 

[lukedirtwalker]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sustrik)

---

go/lib/env/BUILD.bazel, line 37 at r1 (raw file):

    name = "go_default_test",
    srcs = ["features_test.go"],
    data = glob(["testdata/**"]),

This is not needed. Did you not generate this via make gazelle ?

---

go/lib/env/features_test.go, line 27 at r1 (raw file):

	features := reflect.TypeOf(Features{})
	for i := 0; i < features.NumField(); i++ {
		tp := features.Field(i).Type.String()

assert.Equal(t, reflect.Bool, features.Field(i).Type.Kind())

[sustrik]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)

---

go/lib/env/BUILD.bazel, line 37 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

This is not needed. Did you not generate this via make gazelle ?

Gazelle did it, not me.

---

go/lib/env/features_test.go, line 27 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

assert.Equal(t, reflect.Bool, features.Field(i).Type.Kind())

Done.

[sustrik]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)

---

go/lib/env/BUILD.bazel, line 37 at r1 (raw file):

Previously, sustrik (Martin Sustrik) wrote…

Gazelle did it, not me.

Done.

[lukedirtwalker]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

---

go/lib/env/BUILD.bazel, line 37 at r1 (raw file):

Previously, sustrik (Martin Sustrik) wrote…

Done.

hm ok. Weird :)