topology: fix panic and make overBindAddr public #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both PublicOverlay and BindOverlay methods on TopoBRAddr would panic there is no address set for the requested overlay type. This change fixes that and also makes OverBindAddr a public type so it is easier to work with it as the only way to get such objects is by parsing a topology file.
sgmonroy
force-pushed
the
topo-fix-topobr-panic
branch
from
7e1a032 to
622c939
Compare
scrye
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both PublicOverlay and BindOverlay methods on TopoBRAddr would panic
there is no address set for the requested overlay type.
This change fixes that and also makes OverBindAddr a public type so it
is easier to work with it as the only way to get such objects is by
parsing a topology file.
This change is