Feature flags

[sustrik]

This change is 

[lukedirtwalker]

Reviewed 18 of 18 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik)

---

go/lib/env/features.go, line 28 at r1 (raw file):

type Features struct {
	// Following feature flags are used for testing. Do not remove.
	TestA bool

As discussed offline I would remove those flags. Just for having tests it's not worth it. After all the tests don't really test anything that would then be used in production.

[sustrik]

Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

---

go/lib/env/features.go, line 28 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

As discussed offline I would remove those flags. Just for having tests it's not worth it. After all the tests don't really test anything that would then be used in production.

Done.

[lukedirtwalker]

Reviewed 2 of 10 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved