Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing copyrights #2937

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Add missing copyrights #2937

merged 1 commit into from
Jul 30, 2019

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Jul 30, 2019

These should have been added in the past few PRs.


This change is Reviewable

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @sustrik)

a discussion (no related file):
Our convention is to add 2 lines:

// Copyright 2017 ETH Zurich
// Copyright 2019 ETH Zurich, Anapaya Systems

if the date differs.


These should have been added in the past few PRs.
Copy link
Contributor Author

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

a discussion (no related file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Our convention is to add 2 lines:

// Copyright 2017 ETH Zurich
// Copyright 2019 ETH Zurich, Anapaya Systems

if the date differs.

Done.


Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit 799f51d into scionproto:master Jul 30, 2019
@sustrik sustrik deleted the copyrights branch July 30, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants