Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: Use ctx logger for snet path resolver #2885

Merged
merged 1 commit into from
Jul 24, 2019
Merged

log: Use ctx logger for snet path resolver #2885

merged 1 commit into from
Jul 24, 2019

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Jul 22, 2019 •
edited by kormat
Loading

Fixes #2875

This change is Reviewable

@lukedirtwalker lukedirtwalker requested a review from scrye July 22, 2019 15:27
scrye
scrye approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 6c289a1 into scionproto:master Jul 24, 2019
@lukedirtwalker lukedirtwalker deleted the pubUseCtxLogger branch July 24, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrye scrye scrye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

path resolver does not use logger from context
2 participants
@lukedirtwalker @scrye