Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing: Disable tracing by default #2844

Merged
merged 1 commit into from
Jul 16, 2019
Merged

tracing: Disable tracing by default #2844

merged 1 commit into from
Jul 16, 2019

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Jul 16, 2019 •
edited by kormat
Loading

This change is Reviewable

@lukedirtwalker lukedirtwalker requested a review from kormat July 16, 2019 06:13
kormat
kormat approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit efa5d2a into scionproto:master Jul 16, 2019
@lukedirtwalker lukedirtwalker deleted the pubDisableTracingDefault branch July 16, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormat kormat kormat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukedirtwalker @kormat