-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BS,PS: Streamline main #2827
BS,PS: Streamline main #2827
Conversation
* Make sure we call msger.CloseServer() * PS: Start discorunner separately from other tasks * Make kill on a nil periodic.Runner a no-op so that we don't have to have ifs in client code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
go/beacon_srv/main.go, line 501 at r1 (raw file):
t.mtx.Lock() defer t.mtx.Unlock() if !t.running {
This will cause a panic because of double close if !t.running
is that intended?
Also, what is t.running used for now? We can just drop it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @oncilla)
go/beacon_srv/main.go, line 501 at r1 (raw file):
Previously, Oncilla wrote…
This will cause a panic because of double close if
!t.running
is that intended?
Also, what is t.running used for now? We can just drop it.
Good catch! I re-added the if
and set t.running=true
earlier so that we can kill a half started task set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)