Remove request deduplication #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrye
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
go/lib/infra/modules/trust/trust.go, line 175 at r1 (raw file):
func (store *Store) getTRCFromNetwork(ctx context.Context, req *trcRequest) (*trc.TRC, error) {
Extra newline.
lukedirtwalker
commented
Jun 3, 2019
There was a problem hiding this comment.
Reviewable status: 13 of 14 files reviewed, all discussions resolved (waiting on @scrye)
go/lib/infra/modules/trust/trust.go, line 175 at r1 (raw file):
Previously, scrye (Sergiu Costea) wrote…
Extra newline.
Done.
remove cs dedupe
lukedirtwalker
force-pushed
the
pubRemoveDeduper
branch
from
5dafbe4 to
2b7f502
Compare
scrye
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
scrye
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Reviewable status:
lukedirtwalker
added a commit
to lukedirtwalker/scion
that referenced
this pull request
Jun 4, 2019
This reverts commit 274593a. In a more complex environment CI breaks with this commit, so we revert for now.
lukedirtwalker
added a commit
that referenced
this pull request
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is hard to follow requests with the deduplication enabled
(debug id gets lost and it's not clear how to map multiple debug ids to a single dedupe context.)
Furthermore there is no clear evidence that we even save any time in a current real world deployment of scion.
Once we have clear evidence that deduplication needs to be at a certain location we can always readd it, but then we can do a more informed decision where it is actually needed.
This change is