Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add e2e tests for different scenarios #2727

Merged
merged 8 commits into from
May 31, 2019

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented May 29, 2019

This PR adds end-to-end tests for different scenarios.
Based on the source and destination pairs, we allow different
timeouts.


This change is Reviewable

@oncilla oncilla force-pushed the pub-split-end2end-integration branch from e4647e7 to beb78db Compare May 31, 2019 07:28
@oncilla oncilla requested a review from lukedirtwalker May 31, 2019 08:32
@oncilla oncilla added this to the Q3S1 milestone May 31, 2019
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)


go/integration/end2end_integration/main.go, line 125 at r1 (raw file):

		return pairs, nil
	}
	raw, err := ioutil.ReadFile("gen/as_list.yml")

I think you can just use util.LoadASList that provides you with Core and Non-Core AS lists and you can also use the util.ASList instead of redefining it.


integration/e2e_integration, line 21 at r1 (raw file):

shift
opts "$@"
shift $((OPTIND-1))

what is that and the opts line for?

oncilla added 8 commits May 31, 2019 13:22
This PR adds end-to-end tests for different scenarios.
Based on the source and destination pairs, we allow different
timeouts.
Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)


go/integration/end2end_integration/main.go, line 125 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

I think you can just use util.LoadASList that provides you with Core and Non-Core AS lists and you can also use the util.ASList instead of redefining it.

💯
Done.


integration/e2e_integration, line 21 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

what is that and the opts line for?

TBH, idk. Copied from the other scripts.

@oncilla oncilla force-pushed the pub-split-end2end-integration branch from fff010b to 31a597f Compare May 31, 2019 11:32
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


integration/e2e_integration, line 21 at r1 (raw file):

Previously, Oncilla wrote…

TBH, idk. Copied from the other scripts.

🙄 ok

@oncilla oncilla merged commit 608cd40 into scionproto:master May 31, 2019
@oncilla oncilla deleted the pub-split-end2end-integration branch May 31, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants