-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add e2e tests for different scenarios #2727
CI: Add e2e tests for different scenarios #2727
Conversation
e4647e7
to
beb78db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)
go/integration/end2end_integration/main.go, line 125 at r1 (raw file):
return pairs, nil } raw, err := ioutil.ReadFile("gen/as_list.yml")
I think you can just use util.LoadASList
that provides you with Core and Non-Core AS lists and you can also use the util.ASList
instead of redefining it.
integration/e2e_integration, line 21 at r1 (raw file):
shift opts "$@" shift $((OPTIND-1))
what is that and the opts
line for?
This PR adds end-to-end tests for different scenarios. Based on the source and destination pairs, we allow different timeouts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)
go/integration/end2end_integration/main.go, line 125 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
I think you can just use
util.LoadASList
that provides you with Core and Non-Core AS lists and you can also use theutil.ASList
instead of redefining it.
💯
Done.
integration/e2e_integration, line 21 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
what is that and the
opts
line for?
TBH, idk. Copied from the other scripts.
fff010b
to
31a597f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
integration/e2e_integration, line 21 at r1 (raw file):
Previously, Oncilla wrote…
TBH, idk. Copied from the other scripts.
🙄 ok
This PR adds end-to-end tests for different scenarios.
Based on the source and destination pairs, we allow different
timeouts.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)