BS: Add fast recovery unit test

[oncilla]

The added tests check that the fast recovery mechanism works as
expected.

fixes #2685

---

This change is 

[lukedirtwalker]

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @oncilla)

---

go/beacon_srv/internal/beaconing/originator_test.go, line 144 at r1 (raw file):

		// 3. Run where no beacon is sent. -> no call
		// 4. Run where beacons are sent on all interfaces. -> 2 calls
		conn.EXPECT().WriteTo(gomock.Any(), gomock.Any()).Times(5).DoAndReturn(

See comment below, maybe this could be simplified.

---

go/beacon_srv/internal/beaconing/propagator_test.go, line 245 at r1 (raw file):

		}
		g := graph.NewDefaultGraph(mctrl)
		// We call run 4 times in this test

according to the explanation below and the code I wouldn't expect a call in run 3. Why is there one?

---

go/beacon_srv/internal/beaconing/propagator_test.go, line 260 at r1 (raw file):

		// 3. Run where no beacon is sent. -> no call
		// 4. Run where beacons are sent on all interfaces. -> 2 calls
		conn.EXPECT().WriteTo(gomock.Any(), gomock.Any()).Times(5).DoAndReturn(

you could do this more explicit and concise I think:

firstCall := conn.EXPECT().WriteTo(gomock.Any(), gomock.Any())
secondCall := conn.EXPECT().WriteTo(gomock.Any(), gomock.Any()).After(firstCall).Return(errors.New("fail"))
conn.EXPECT().WriteTo(gomock.Any(), gomock.Any()).After(secondCall).Times(3)

(didn't test it though)

---

go/beacon_srv/internal/beaconing/propagator_test.go, line 276 at r1 (raw file):

		// Second run. One write expected.
		p.Run(nil)
		// Third run. No write expected

hm this can't really be verified, but the total is good enough -ish

[oncilla]

Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker)

---

go/beacon_srv/internal/beaconing/originator_test.go, line 144 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

See comment below, maybe this could be simplified.

Done.

---

go/beacon_srv/internal/beaconing/propagator_test.go, line 245 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

according to the explanation below and the code I wouldn't expect a call in run 3. Why is there one?

Done.

---

go/beacon_srv/internal/beaconing/propagator_test.go, line 260 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

you could do this more explicit and concise I think:

firstCall := conn.EXPECT().WriteTo(gomock.Any(), gomock.Any())
secondCall := conn.EXPECT().WriteTo(gomock.Any(), gomock.Any()).After(firstCall).Return(errors.New("fail"))
conn.EXPECT().WriteTo(gomock.Any(), gomock.Any()).After(secondCall).Times(3)

(didn't test it though)

Nice.

---

go/beacon_srv/internal/beaconing/propagator_test.go, line 276 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

hm this can't really be verified, but the total is good enough -ish

Sure, but its good enough I think.

[lukedirtwalker]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved