BS: Improve unit test for recentness of revocation #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShouldBeBetween doesn't include the bound. In case the revocation was issued the second before the test creates the now value, the test would fail on the lower bound. (see https://buildkite.com/scionproto/scionproto-nightly/builds/228#e8f2c1cb-6d69-4852-89fa-d88953df795b) Fix the check: The revocation can either have - A timestamp with a second value 1 less than now, or - A timestamp with the same second value.
oncilla
approved these changes
May 10, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShouldBeBetween doesn't include the bound.
In case the revocation was issued the second before the test creates the now value,
the test would fail on the lower bound.
(see https://buildkite.com/scionproto/scionproto-nightly/builds/228#e8f2c1cb-6d69-4852-89fa-d88953df795b)
Fix the check: The revocation can either have
This change is