SIG: Avoid capturing the remote SIG info in the session

[oncilla]

The session monitor stores its working object into the session, instead
of a snaphot object. This can lead to weird interactions, when the
monitoring times out, and the host is set to an SVC address.
This will cause data traffic to reach the ctrl port of the SIG.

---

This change is 

[sustrik]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @oncilla and @sustrik)

---

go/sig/egress/session/sessmon.go, line 190 at r1 (raw file):

	// XXX(roosd): Data traffic should never be sent to a SVC address.
	if remote.Sig.Host.Equal(addr.SvcSIG) {
		remote.Sig = sm.sess.Remote().Sig

Shouldn't we just return here? What's the point of partially updating the session state?

[oncilla]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @sustrik)

---

go/sig/egress/session/sessmon.go, line 190 at r1 (raw file):

Previously, sustrik (Martin Sustrik) wrote…

Shouldn't we just return here? What's the point of partially updating the session state?

This changes the path. As we do not know, whether the path is unhealthy, or the remote sig is unhealthy. Changing the path could result in traffic reaching the remote.

[sustrik]

Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved