Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: Ensure bazel files are consistent #2590

Merged
merged 3 commits into from
Apr 11, 2019

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Apr 10, 2019

This PR changes the linter to ensure that the bazel files
do not differ from the auto generated files.

fixes #2582


This change is Reviewable

This PR changes the linter to ensure that the bazel files
do not differ from the auto generated files.

fixes scionproto#2582
@oncilla oncilla requested a review from sustrik April 10, 2019 15:47
@oncilla oncilla self-assigned this Apr 10, 2019
@oncilla oncilla added this to the Q2S1 milestone Apr 10, 2019
Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @oncilla)

Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @oncilla)

@oncilla oncilla merged commit 756368a into scionproto:master Apr 11, 2019
@oncilla oncilla deleted the pub-ensure-consistent branch April 11, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bazel: Make sure BUILD.bazel files cannot diverge from generated output
2 participants