Construct Infra Messenger from Configs only #2506
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker and @scrye)
go/lib/infra/messenger/messenger.go, line 129 at r1 (raw file):
} func (c *Config) loadDefaults() {
I know this is not a config that is loaded from FS. But it might be useful to do the InitDefaults pattern here.
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye)
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker and @oncilla)
go/lib/infra/messenger/messenger.go, line 129 at r1 (raw file):
Previously, Oncilla wrote…
I know this is not a config that is loaded from FS. But it might be useful to do the
InitDefaultspattern here.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
This simplifies integrating the QUIC RPC layer in the Messenger.
This change is