Acceptance tests: Collect and save metrics

[worxli]

Also contributes to #2153.

This change is 

[lukedirtwalker]

Reviewed 19 of 19 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @worxli)

---

acceptance/common.sh, line 11 at r1 (raw file):

}

collect_metrics() {

I think we should start to document lib function. At least describe the arguments.
Also this seems to only work for BR and SIGs.

---

acceptance/common.sh, line 17 at r1 (raw file):

(jq '.BorderRouters | to_entries[] | .key' $1)

Possibly simpler: jq -r '.BorderRouters | keys | .[]' $1 note the -r removes the quotes so you no longer need the remove_quotes function

---

python/topology/docker.py, line 176 at r1 (raw file):

                sciond = get_default_sciond_path(ISD_AS(topo["ISD_AS"]))
                entry['command'].append('--spki_cache_dir=cache')
                entry['command'].append('--prom=[0.0.0.0]:%s' % CS_PROM_PORT)

We need 0.0.0.0 because of docker here?

[worxli]

Reviewable status: 15 of 19 files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker)

---

acceptance/common.sh, line 11 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

I think we should start to document lib function. At least describe the arguments.
Also this seems to only work for BR and SIGs.

Done.

---

acceptance/common.sh, line 17 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

(jq '.BorderRouters | to_entries[] | .key' $1)

Possibly simpler: jq -r '.BorderRouters | keys | .[]' $1 note the -r removes the quotes so you no longer need the remove_quotes function

Done.

---

python/topology/docker.py, line 176 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

We need 0.0.0.0 because of docker here?

Yes. We bind to 0.0.0.0 so we can access the metrics on the container IP from the host.

[lukedirtwalker]

Reviewed 4 of 4 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[lukedirtwalker]

Reviewed 1 of 2 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved

[lukedirtwalker]

Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved